Skip to content

Fix iframe attribute spacing in Chinese frames documentation#2563

Merged
harsha509 merged 3 commits into
SeleniumHQ:trunkfrom
RReval102:fix-zh-cn-iframe-attrs
Jan 21, 2026
Merged

Fix iframe attribute spacing in Chinese frames documentation#2563
harsha509 merged 3 commits into
SeleniumHQ:trunkfrom
RReval102:fix-zh-cn-iframe-attrs

Conversation

@RReval102
Copy link
Copy Markdown
Contributor

@RReval102 RReval102 commented Jan 14, 2026 •
edited
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Fixes invalid HTML in the Chinese version of the frames documentation by adding
missing spaces between iframe attributes. This makes the example consistent
with the English version and valid HTML.

Motivation and Context

The iframe example in frames.zh-cn.md had concatenated attributes
(id, name, src) without spaces, which makes the HTML invalid and confusing.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation

Description

  • Fix spacing in HTML iframe attributes in Chinese documentation

  • Adds proper spaces between iframe attributes for readability

Diagram Walkthrough

flowchart LR
  A["Chinese frames.zh-cn.md"] -- "Add spaces between attributes" --> B["Properly formatted iframe tag"]
Loading

File Walkthrough
Relevant files
Documentation
frames.zh-cn.md
Add spacing between iframe attributes                                       

website_and_docs/content/documentation/webdriver/interactions/frames.zh-cn.md

  • Fixed spacing in iframe HTML element attributes
  • Changed id="buttonframe"name="myframe"src= to id="buttonframe"
    name="myframe" src=
  • Improves code readability and follows HTML formatting standards
 +1/-1     

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 14, 2026 •
edited
Loading

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 51c6bdd

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 14, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Jan 14, 2026 •
edited
Loading

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Jan 14, 2026 •
edited
Loading

PR Code Suggestions ✨

No code suggestions found for the PR.

@RReval102
Copy link
Copy Markdown
Contributor Author

RReval102 commented Jan 15, 2026

CLA signed. Thank you for reviewing!

harsha509
harsha509 approved these changes Jan 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
Thank you @RReval102 !

@harsha509 harsha509 merged commit 149c673 into SeleniumHQ:trunk Jan 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsha509 harsha509 harsha509 approved these changes

Assignees

No one assigned

Labels

Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RReval102 @CLAassistant @harsha509